|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH] hw/pl061: Remove pointless comparison of array to null |
Date: | Fri, 11 Nov 2011 13:45:19 -0600 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.21) Gecko/20110831 Lightning/1.0b2 Thunderbird/3.1.13 |
On 11/09/2011 02:04 PM, Peter Maydell wrote:
Remove a pointless comparison of an array to null. (There is no need to check whether s->out[i] is non-null as qemu_set_irq will do that for us.) Spotted by Coverity (see bug 887883). Signed-off-by: Peter Maydell<address@hidden>
Applied. Thanks. Regards, Anthony Liguori
--- hw/pl061.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pl061.c b/hw/pl061.c index d13746c..cf5adbe 100644 --- a/hw/pl061.c +++ b/hw/pl061.c @@ -103,7 +103,7 @@ static void pl061_update(pl061_state *s) s->old_data = out; for (i = 0; i< 8; i++) { mask = 1<< i; - if ((changed& mask)&& s->out) { + if (changed& mask) { DPRINTF("Set output %d = %d\n", i, (out& mask) != 0); qemu_set_irq(s->out[i], (out& mask) != 0); }
[Prev in Thread] | Current Thread | [Next in Thread] |