|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH 4/4] Makefile: fix qga dependencies |
Date: | Thu, 17 Nov 2011 10:31:27 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1 |
On 11/16/2011 10:58 PM, Michael S. Tsirkin wrote:
.c files include .h files, so .o depends on .h, and the linked result depends on .o. We got it wrong for qga rules, fix it up.
Another possible option is to make the "all" target depend on GENERATED_HEADERS and GENERATED_SOURCES, like
all: $(GENERATED_HEADERS) $(GENERATED_SOURCES) @$(MAKE) build-alland drop the dependency everywhere else. This will check the dependency at the beginning of the build (should be fine since the generated files change rarely) and rely on automatic dependency generation for the .o->.h dependencies.
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |