[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 5/9] qcow2: Rework qcow2_snapshot_create erro
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v2 5/9] qcow2: Rework qcow2_snapshot_create error handling |
Date: |
Tue, 22 Nov 2011 10:14:43 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 |
Am 21.11.2011 17:47, schrieb Stefan Hajnoczi:
> On Fri, Nov 18, 2011 at 6:29 PM, Kevin Wolf <address@hidden> wrote:
>> + /*
>> + * Increase the refcounts of all clusters and make sure everything is
>> + * stable on disk before updating the snapshot table to contain a
>> pointer
>> + * to the new L1 table.
>> + */
>> + ret = qcow2_update_snapshot_refcount(bs, s->l1_table_offset,
>> s->l1_size, 1);
>> + if (ret < 0) {
>> + goto fail;
>> + }
>> +
>> + ret = bdrv_flush(bs->file);
>
> Do we need to explicitly flush the qcow2 cache to ensure metadata
> reaches the disk?
Yes, I think this should be a bdrv_flush(bs). I'm not completely sure if
it is really required, but I couldn't immediately tell why it's safe and
this isn't a fast path anyway, so I'll replace this before merging the
series (won't send out a v3 for this).
Kevin
- [Qemu-devel] [PATCH v2 0/9] qcow2: Fix error paths for internal snapshots, Kevin Wolf, 2011/11/18
- [Qemu-devel] [PATCH v2 4/9] qcow2: Cleanups and memleak fix in qcow2_snapshot_create, Kevin Wolf, 2011/11/18
- [Qemu-devel] [PATCH v2 2/9] qcow2: Return real error code in qcow2_write_snapshots, Kevin Wolf, 2011/11/18
- [Qemu-devel] [PATCH v2 8/9] qcow2: Fix order in qcow2_snapshot_delete, Kevin Wolf, 2011/11/18
- [Qemu-devel] [PATCH v2 7/9] qcow2: Fix order of refcount updates in qcow2_snapshot_goto, Kevin Wolf, 2011/11/18
- [Qemu-devel] [PATCH v2 9/9] qcow2: Fix error path in qcow2_snapshot_load_tmp, Kevin Wolf, 2011/11/18
- [Qemu-devel] [PATCH v2 6/9] qcow2: Return real error in qcow2_snapshot_goto, Kevin Wolf, 2011/11/18
- Re: [Qemu-devel] [PATCH v2 0/9] qcow2: Fix error paths for internal snapshots, Stefan Hajnoczi, 2011/11/21