qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] linux-user/strace.c: Correct errno printing for


From: Alexander Graf
Subject: Re: [Qemu-devel] [PATCH] linux-user/strace.c: Correct errno printing for mmap etc
Date: Wed, 23 Nov 2011 14:18:56 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.14) Gecko/20110221 SUSE/3.1.8 Thunderbird/3.1.8

On 11/23/2011 02:15 PM, Riku Voipio wrote:
On Mon, Nov 21, 2011 at 12:21:19PM +0000, Peter Maydell wrote:
Correct the printing of errnos for syscalls which are handled
via print_syscall_ret_addr (mmap, mmap2, brk, shmat): errnos
are returned as negative returned values at this level, not
via the host 'errno' variable.

Signed-off-by: Peter Maydell<address@hidden>
---
This applies on top of Alex's [v3] linux-user: fix QEMU_STRACE=1 segfault
patch. It is fixing a separate bug to that patch, but OTOH it does touch
only four lines of actual code, all of which were added in that patch.
Keep it separate or fold it in with that one, I don't mind.
I think in general it is recommended to squash patches that only change lines
added in the previous patch. Otoh it muddies the authorship of the change.
Thus, unless someone objects, I'll que these as separate patches so both
of you get clear credit.

I am completely indifferent :).


Alex




reply via email to

[Prev in Thread] Current Thread [Next in Thread]