[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 00/11] more memory API conversions
From: |
Avi Kivity |
Subject: |
Re: [Qemu-devel] [PATCH v4 00/11] more memory API conversions |
Date: |
Thu, 24 Nov 2011 15:44:11 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 |
On 11/24/2011 03:31 PM, Benoît Canet wrote:
> These patches convert some files to memory API
>
> I am wondering if the bonito ones are corrects as
> sysbus_mmio_map() use internally get_system_memory().
>From a "will it work" perspective, I think it's correct since it
system_memory is supposed to be equivalent to
cpu_register_physical_memory().
>From an "is this the right thing", well, we'll need to hack up sysbus
not to call get_system_memory() itself, but that's an unrelated problem.
> v2:
> remove unneeded casts in mcf_uart
> remove unneeded #include in lm32_uart and lm32_sys
>
> v3:
> use valid.accept in lm32_sys
>
> v4:
> bonito: use the pci_host sysbus pointer
> bonito: use pci_host->conf_mem and pci_host->data_mem
>
Looks good to me. I'll apply next week to allow people to review.
--
error compiling committee.c: too many arguments to function
- [Qemu-devel] [PATCH v4 05/11] lm32_uart: convert to memory API, (continued)
- [Qemu-devel] [PATCH v4 05/11] lm32_uart: convert to memory API, Benoît Canet, 2011/11/24
- [Qemu-devel] [PATCH v4 03/11] mcf_fec: convert to memory API, Benoît Canet, 2011/11/24
- [Qemu-devel] [PATCH v4 06/11] lm32_sys: convert to memory API, Benoît Canet, 2011/11/24
- [Qemu-devel] [PATCH v4 02/11] mcf_uart: convert to memory API, Benoît Canet, 2011/11/24
- [Qemu-devel] [PATCH v4 07/11] bonito: convert north bridge register mapping to memory API, Benoît Canet, 2011/11/24
- [Qemu-devel] [PATCH v4 11/11] bonito: convert cop to memory API, Benoît Canet, 2011/11/24
- [Qemu-devel] [PATCH v4 10/11] bonito: convert ldma to memory API, Benoît Canet, 2011/11/24
- [Qemu-devel] [PATCH v4 08/11] bonito: convert north bridge pci config to memory API, Benoît Canet, 2011/11/24
- Re: [Qemu-devel] [PATCH v4 00/11] more memory API conversions,
Avi Kivity <=
- Re: [Qemu-devel] [PATCH v4 00/11] more memory API conversions, Avi Kivity, 2011/11/27