[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [qemu-kvm PATCH 1/1] don't try to hotplug a cpu
From: |
Serge Hallyn |
Subject: |
[Qemu-devel] [qemu-kvm PATCH 1/1] don't try to hotplug a cpu |
Date: |
Thu, 1 Dec 2011 11:14:19 -0600 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
When you do "cpu_set <n> online" where <n> > current number of cpus,
qemu-kvm will end up crashing when qdev finds hotplug is not enabled.
Let's instead gracefully refuse.
See https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/878422 for
the related bug report.
Signed-off-by: Serge Hallyn <address@hidden>
---
hw/acpi_piix4.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
index 1b35707..5e95569 100644
--- a/hw/acpi_piix4.c
+++ b/hw/acpi_piix4.c
@@ -589,12 +589,17 @@ void qemu_system_cpu_hot_add(int cpu, int state)
PIIX4PMState *s = global_piix4_pm_state;
if (state && !qemu_get_cpu(cpu)) {
+#if 1
+ fprintf(stderr, "cpu hotplug not supported\n", cpu);
+ return;
+#else
env = pc_new_cpu(global_cpu_model);
if (!env) {
fprintf(stderr, "cpu %d creation failed\n", cpu);
return;
}
env->cpuid_apic_id = cpu;
+#endif
}
if (state)
--
1.7.5.4
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-devel] [qemu-kvm PATCH 1/1] don't try to hotplug a cpu,
Serge Hallyn <=