[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Guest stop notification
From: |
Arend van Spriel |
Subject: |
Re: [Qemu-devel] [PATCH] Guest stop notification |
Date: |
Thu, 1 Dec 2011 18:31:56 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:8.0) Gecko/20111124 Thunderbird/8.0 |
On 12/01/2011 06:19 PM, Eric B Munson wrote:
> On Thu, 01 Dec 2011, Jan Kiszka wrote:
>
>> On 2011-11-29 22:36, Eric B Munson wrote:
>>> +
>>> static void cpu_update_state(void *opaque, int running, RunState state)
>>> {
>>> CPUState *env = opaque;
>>>
>>> if (running) {
>>> env->tsc_valid = false;
>>> + kvm_put_guest_paused(env);
>>
>> checkpatch.pl would have asked you to remove this tab.
>
> Will change to spaces for V2.
>
Huh. Remove what tab? Indent are always 8-space TAB according
CodingStyle doc:
Chapter 1: Indentation
Tabs are 8 characters, and thus indentations are also 8 characters.
There are heretic movements that try to make indentations 4 (or even 2!)
characters deep, and that is akin to trying to define the value of PI to
be 3.
Gr. AvS