Re: [Qemu-devel] [PATCH v2 0/8] [RFC] vmstate: Add copyrights for all cpus

[Andreas Färber]

Am 27.11.2011 14:30, schrieb Juan Quintela:
> Andreas Färber <address@hidden> wrote:
>> Hi Juan,
>>
>> Am 23.11.2011 16:44, schrieb Juan Quintela:
>>> [ Resnd this time also ading fabrice address, sorry ]
>>>
>>> v2:
>>> - split patches by file, make easier to add "acked-by" notices.
>>> - cc'd fabrice
>>> - everybody (except for Thiemo for ovbious reasons) answered.
>>> - move ppc/sparc/i386 to BSD like license from vl.c at Blue
>>>   suggestion. 
>>>
>>> - move all other licenses to GPL v2 or later (notice that I had forget
>>>   the later part on the 1st submission).  Notice this change for the
>>>   people that acked previous version.
>>>
>>> Any other comments?
>>
>> I did have another comment regarding the "Based on" part that you
>> haven't responded to yet.
> 
> Sorry, forgot about that one.  What text do you propose?
> 
> * Based on serialization based on QEMUFile done by:
> 
> ????
> 
> Any other proposal?

Keep it short and simple. Off the top of my head:

* Based on serialization code by:

(don't see what qemu-file / QEMUFile has to do with it?)

* Based on savevm code by:

(yeah, it's not just that but still a better keyword than qemu-file IMO)

But maybe I'm just misunderstanding something here?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg