[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/6] Memory API mutators
From: |
Avi Kivity |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/6] Memory API mutators |
Date: |
Wed, 07 Dec 2011 17:54:41 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 |
On 12/07/2011 05:52 PM, Anthony Liguori wrote:
> On 12/04/2011 12:09 PM, Avi Kivity wrote:
>> This patchset introduces memory_region_set_enabled() and
>> memory_region_set_address() to avoid the requirement on memory
>> routers to track the internal state of the memory API (so they know
>> whether they need to add or remove a region). Instead, they can
>> simply copy the state of the region from the guest-exposed register
>> to the memory core, via the new mutator functions.
>
> Based on previous discussions, any time these functions are used, the
> caller more than likely needs to call them again in a post_load hook
> during restore, correct?
>
> It would be good to document this very clearly in the header docs for
> each function.
It's a layering violation, but I'll add something.
--
error compiling committee.c: too many arguments to function
- [Qemu-devel] [PATCH v2 0/6] Memory API mutators, Avi Kivity, 2011/12/04
- [Qemu-devel] [PATCH v2 4/6] memory: optimize empty transactions due to mutators, Avi Kivity, 2011/12/04
- [Qemu-devel] [PATCH v2 2/6] memory: introduce memory_region_set_address(), Avi Kivity, 2011/12/04
- [Qemu-devel] [PATCH v2 6/6] piix_pci: adapt smram mapping to use memory mutators, Avi Kivity, 2011/12/04
- [Qemu-devel] [PATCH v2 3/6] memory: introduce memory_region_set_alias_offset(), Avi Kivity, 2011/12/04
- [Qemu-devel] [PATCH v2 1/6] memory: introduce memory_region_set_enabled(), Avi Kivity, 2011/12/04
- [Qemu-devel] [PATCH v2 5/6] cirrus_vga: adapt to memory mutators API, Avi Kivity, 2011/12/04
- Re: [Qemu-devel] [PATCH v2 0/6] Memory API mutators, Anthony Liguori, 2011/12/07
- Re: [Qemu-devel] [PATCH v2 0/6] Memory API mutators,
Avi Kivity <=