|
From: | Stefan Weil |
Subject: | Re: [Qemu-devel] [PATCH] configure: don't try to compile against known broken curses. |
Date: | Wed, 07 Dec 2011 19:57:29 +0100 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.23) Gecko/20110921 Thunderbird/3.1.15 |
Am 07.12.2011 08:47, schrieb Andrzej Zaborowski:
This should resolve a problem noted by Caraman Mihai Claudiu. Signed-off-by: Andrzej Zaborowski <address@hidden> --- configure | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 61c43b9..678b982 100755 --- a/configure +++ b/configure @@ -1846,6 +1846,11 @@ if test "$curses" != "no" ; then #ifdef __OpenBSD__ #define resize_term resizeterm #endif +#ifdef NCURSES_VERSION +# if NCURSES_VERSION_PATCH < 20040117+# error Old ncurses contain dangerous typedefs, break qemu build (and are old)+# endif +#endif int main(void) { resize_term(0, 0); return curses_version(); } EOF for curses_lib in $curses_list; do
Is NCURSES_VERSION_PATCH always defined when NCURSES_VERSION is? If not, code like the following is more robust: #if !defined(NCURSES_VERSION_PATCH) || NCURSES_VERSION_PATCH < 20040117# error Old ncurses contain dangerous typedefs, break qemu build (and are old)
#endif Otherwise the patch is good. Reviewed-by: Stefan Weil <address@hidden>
[Prev in Thread] | Current Thread | [Next in Thread] |