[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 16/18] qom: optimize qdev_get_canonical_path
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v2 16/18] qom: optimize qdev_get_canonical_path using a parent link |
Date: |
Fri, 09 Dec 2011 12:13:57 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 |
Am 02.12.2011 21:20, schrieb Anthony Liguori:
> The full tree search was a bit unreasonable.
>
> Signed-off-by: Anthony Liguori <address@hidden>
> diff --git a/hw/qdev.h b/hw/qdev.h
> index 4351e2e..fdab848 100644
> --- a/hw/qdev.h
> +++ b/hw/qdev.h
> @@ -92,6 +92,10 @@ struct DeviceState {
> uint32_t ref;
>
> QTAILQ_HEAD(, DeviceProperty) properties;
> +
> + /* Do not, under any circumstance, use this parent link below anywhere
> + * outside of qdev.c. You have been warned. */
> + DeviceState *parent;
> };
I would expect that a warning works better if it tells people _why_
their code will break if they do it anyway (it's not clear to me)
Kevin
- [Qemu-devel] [PATCH v2 10/18] qmp: add qom-list command, (continued)
- [Qemu-devel] [PATCH v2 10/18] qmp: add qom-list command, Anthony Liguori, 2011/12/02
- [Qemu-devel] [PATCH v2 13/18] dev: add an anonymous peripheral container, Anthony Liguori, 2011/12/02
- [Qemu-devel] [PATCH v2 12/18] qdev: add explicitly named devices to the root complex, Anthony Liguori, 2011/12/02
- [Qemu-devel] [PATCH v2 09/18] qapi: allow a 'gen' key to suppress code generation, Anthony Liguori, 2011/12/02
- [Qemu-devel] [PATCH v2 14/18] rtc: make piix3 set the rtc as a child (v2), Anthony Liguori, 2011/12/02
- [Qemu-devel] [PATCH v2 16/18] qom: optimize qdev_get_canonical_path using a parent link, Anthony Liguori, 2011/12/02
- Re: [Qemu-devel] [PATCH v2 16/18] qom: optimize qdev_get_canonical_path using a parent link,
Kevin Wolf <=
- [Qemu-devel] [PATCH v2 18/18] qom: add test tools (v2), Anthony Liguori, 2011/12/02
- [Qemu-devel] [PATCH v2 17/18] qmp: make qmp.py easier to use, Anthony Liguori, 2011/12/02
- [Qemu-devel] [PATCH v2 15/18] rtc: add a dynamic property for retrieving the date, Anthony Liguori, 2011/12/02
- Re: [Qemu-devel] [PATCH v2 15/18] rtc: add a dynamic property for retrieving the date, Kevin Wolf, 2011/12/09
- Re: [Qemu-devel] [PATCH v2 15/18] rtc: add a dynamic property for retrieving the date, Anthony Liguori, 2011/12/09
- Re: [Qemu-devel] [PATCH v2 15/18] rtc: add a dynamic property for retrieving the date, Kevin Wolf, 2011/12/09
- Re: [Qemu-devel] [PATCH v2 15/18] rtc: add a dynamic property for retrieving the date, Anthony Liguori, 2011/12/09
- Re: [Qemu-devel] [PATCH v2 15/18] rtc: add a dynamic property for retrieving the date, Kevin Wolf, 2011/12/13
- Re: [Qemu-devel] [PATCH v2 15/18] rtc: add a dynamic property for retrieving the date, Gerd Hoffmann, 2011/12/13