|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH] spapr: Add support for -vga option |
Date: | Wed, 14 Dec 2011 18:10:50 -0600 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.21) Gecko/20110831 Lightning/1.0b2 Thunderbird/3.1.13 |
On 12/14/2011 06:00 PM, Benjamin Herrenschmidt wrote:
On Wed, 2011-12-14 at 15:48 -0600, Anthony Liguori wrote:/* USB */ if (usb_enabled) {usb_ohci_init_pci(QLIST_FIRST(&spapr->phbs)->host_state.bus, -1);+ if (spapr_has_graphics) { + usbdevice_create("keyboard"); + usbdevice_create("mouse");It is better to use usb_create() and pass it the usb bus directly as this will make it easier to express this as composition down the road.How do I do that ? usb_ohci_init_pci() doesn't appear to return the USB bus....
Let's make it... I'll send a patch. Regards, Anthony Liguori
Cheers, Ben.
[Prev in Thread] | Current Thread | [Next in Thread] |