|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH v6 4/4] Add support for net bridge |
Date: | Mon, 19 Dec 2011 17:15:40 -0600 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110922 Lightning/1.0b2 Thunderbird/3.1.15 |
On 12/19/2011 04:55 PM, Corey Bryant wrote:
diff --git a/net.c b/net.c index f7bebf8..9296224 100644 --- a/net.c +++ b/net.c @@ -952,6 +952,14 @@ static const struct { .type = QEMU_OPT_STRING, .help = "script to shut down the interface", }, { + .name = "br", + .type = QEMU_OPT_STRING, + .help = "bridge name", + }, {I don't think passing br= makes a whole of sense for -net tap. I think it would make more sense to make sure that helper could take a shell string so you could do: -netdev tap,helper="/usr/libexec/qemu-bridge-helper --br=br0" Regards, Anthony LiguoriOk but do you think the -net bridge options should remain as-is? It seems like execution of the helper should be consistent. Here are the current options for -net bridge: -net bridge,helper=/usr/local/libexec/qemu-bridge-helper,br=br0
Yes. -net bridge is syntactic sugar for -net tap with specific knowledge of the qemu-bridge-helper.
If someone wrote a 'qemu-openvswitch-helper' then you could imagine a '-net openvswitch' option that passed a bunch of openvswitch specific arguments.
Regards, Anthony Liguori
[Prev in Thread] | Current Thread | [Next in Thread] |