[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 00/16] uq/master: Introduce basic irqchip sup
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH v5 00/16] uq/master: Introduce basic irqchip support |
Date: |
Tue, 20 Dec 2011 01:37:37 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2011-12-20 01:32, Anthony Liguori wrote:
> On 12/19/2011 05:49 PM, Jan Kiszka wrote:
>> On 2011-12-19 23:24, Anthony Liguori wrote:
>>> On 12/19/2011 03:17 PM, Marcelo Tosatti wrote:
>>>>
>>>> Anthony,
>>>>
>>>> Can you please review& ACK?
>>>>
>>>> You could even apply directly but well do a kvm-autotest run through
>>>> uq/master. Still, your review is needed.
>>>
>>> Overall, it looks good except for the backend/frontend split. This
>>> should be done in terms of qdev inheritance.
>>
>> I cannot follow your idea here yet. There is no inheritance as we end up
>> with only a single class that permutes (selects a different backend) on
>> creation. I'm not sure how to model two classes that will still only
>> mean a single qdev registration.
>
> See other reply in thread.
>
> We should model this as two separate qdev devices. We can avoid
> regressing migration in qemu-kvm by just having a common vmstate name.
>
> apic is a no-user device so there's no way that changing the name of it
> in qemu-kvm can affect users.
Look down http://thread.gmane.org/gmane.comp.emulators.kvm.devel/82598
for the discussion of that model.
Jan
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v5 09/16] ioapic: Introduce backend/frontend infrastructure for KVM reuse, Jan Kiszka, 2011/12/15
[Qemu-devel] [PATCH v5 04/16] apic: Inject external NMI events via LINT1, Jan Kiszka, 2011/12/15
[Qemu-devel] [PATCH v5 13/16] kvm: x86: Add user space part for in-kernel APIC, Jan Kiszka, 2011/12/15
Re: [Qemu-devel] [PATCH v5 00/16] uq/master: Introduce basic irqchip support, Marcelo Tosatti, 2011/12/19
- Re: [Qemu-devel] [PATCH v5 00/16] uq/master: Introduce basic irqchip support, Anthony Liguori, 2011/12/19
- Re: [Qemu-devel] [PATCH v5 00/16] uq/master: Introduce basic irqchip support, Anthony Liguori, 2011/12/19
- Re: [Qemu-devel] [PATCH v5 00/16] uq/master: Introduce basic irqchip support, Jan Kiszka, 2011/12/19
- Re: [Qemu-devel] [PATCH v5 00/16] uq/master: Introduce basic irqchip support, Jan Kiszka, 2011/12/19
- Re: [Qemu-devel] [PATCH v5 00/16] uq/master: Introduce basic irqchip support, Anthony Liguori, 2011/12/19
- Re: [Qemu-devel] [PATCH v5 00/16] uq/master: Introduce basic irqchip support, Anthony Liguori, 2011/12/19
- Re: [Qemu-devel] [PATCH v5 00/16] uq/master: Introduce basic irqchip support, Jan Kiszka, 2011/12/20
Re: [Qemu-devel] [PATCH v5 00/16] uq/master: Introduce basic irqchip support, Avi Kivity, 2011/12/20
Re: [Qemu-devel] [PATCH v5 00/16] uq/master: Introduce basic irqchip support, Avi Kivity, 2011/12/20