[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/integratorcp: Simplify flash remap code, fix
|
From: |
Avi Kivity |
|
Subject: |
Re: [Qemu-devel] [PATCH] hw/integratorcp: Simplify flash remap code, fix sense of REMAP bit |
|
Date: |
Tue, 20 Dec 2011 13:00:19 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 |
On 12/19/2011 06:45 PM, Peter Maydell wrote:
> Use the new memory mutator API to simplify the flash remap code;
> this allows us to drop the flash_mapped flag.
>
> This patch also fixes the sense of the REMAP bit, which was
> reversed.
>
I'm surprised the word "also" doesn't cause the maintainers' scripts to
auto-reject the patch. It makes the patch hard to review, and also
makes cherry picking for updating stable releases harder.
--
error compiling committee.c: too many arguments to function