|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH v5 06/16] apic: Introduce backend/frontend infrastructure for KVM reuse |
Date: | Tue, 20 Dec 2011 08:07:40 -0600 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110922 Lightning/1.0b2 Thunderbird/3.1.15 |
On 12/20/2011 07:57 AM, Paolo Bonzini wrote:
On 12/20/2011 02:54 PM, Anthony Liguori wrote:In QOM parlance Jan implemented this: abstract class Object abstract class Device class APIC: { backend: link<APICBackend> } abstract class APICBackend class QEMU_APICBackend class KVM_APICBackendI don't fundamentally object to modeling it like this provided that it's modeled (and visible) through qdev and not done through a one-off infrastructure.There is no superclass of DeviceState, hence doing it through qdev would mean introducing a new bus type and so on. This would be a superb example of a useless bus that can disappear with QOM, but I don't see why we should take the pain to add it in the first place. :)
Right, so let's modeled it for now as inheritance which qdev can cope with.
We sure can revisit this when the subclassing and interface infrastructures of QOM are merged.
I'll have patches out this week (just trying to write some more test cases). The latest series is below if you're interested. I fear that it won't be until mid to late January before this can be merged though as I want to give folks like Markus a chance to review it.
https://github.com/aliguori/qemu/tree/qom-upstream.3 Regards, Anthony Liguori
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |