[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC][PATCH 8/8 v3] introduce a new monitor command 'du
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC][PATCH 8/8 v3] introduce a new monitor command 'dump' to dump guest's memory |
Date: |
Tue, 20 Dec 2011 09:25:53 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 |
On 12/20/2011 02:15 AM, Wen Congyang wrote:
> Signed-off-by: Wen Congyang <address@hidden>
> ---
> Makefile.target | 8 +-
> dump.c | 452
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> dump.h | 4 +
> hmp-commands.hx | 16 ++
> monitor.c | 3 +
> qmp-commands.hx | 24 +++
> 6 files changed, 503 insertions(+), 4 deletions(-)
> create mode 100644 dump.c
>
> +++ b/qmp-commands.hx
> @@ -469,6 +469,30 @@ Notes:
> EQMP
>
> {
> + .name = "dump",
> + .args_type = "file:s",
> + .params = "file",
> + .help = "dump to file",
> + .user_print = monitor_user_noop,
> + .mhandler.cmd_new = do_dump,
> + },
From a libvirt perspective, we would like the option to be able to pass
in an already-open fd rather than just a file name. This is possible if
the 'file' argument is required to start with '/' for an absolute path,
vs. 'file:name' for an fd previously passed in via the getfd monitor
command.
Also, does this command block? It sounds like it is long-running, which
means it probably needs to be asynchronous, as well as issue an event
upon completion, so that other monitor commands can be issued in the
meantime.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC][PATCT 0/8 v3] dump memory when host pci device is used by guest, Wen Congyang, 2011/12/20
- [Qemu-devel] [RFC][PATCH 1/8 v3] Add API to create memory mapping list, Wen Congyang, 2011/12/20
- [Qemu-devel] [RFC][PATCH 2/8 v3] Add API to check whether a physical address is I/O address, Wen Congyang, 2011/12/20
- [Qemu-devel] [RFC][PATCH 3/8 v3] target-i386: implement cpu_get_memory_mapping(), Wen Congyang, 2011/12/20
- [Qemu-devel] [RFC][PATCH 4/8 v3] Add API to get memory mapping, Wen Congyang, 2011/12/20
- [Qemu-devel] [RFC][PATCH 5/8 v3] target-i386: Add API to write elf notes to core file, Wen Congyang, 2011/12/20
- [Qemu-devel] [RFC][PATCH 6/8 v3] target-i386: Add API to add extra memory mapping, Wen Congyang, 2011/12/20
- [Qemu-devel] [RFC][PATCH 7/8 v3] target-i386: add API to get dump info, Wen Congyang, 2011/12/20
- [Qemu-devel] [RFC][PATCH 8/8 v3] introduce a new monitor command 'dump' to dump guest's memory, Wen Congyang, 2011/12/20
- Re: [Qemu-devel] [RFC][PATCH 8/8 v3] introduce a new monitor command 'dump' to dump guest's memory,
Eric Blake <=