[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 14/23] vhost: convert to MemoryListener API
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 14/23] vhost: convert to MemoryListener API |
Date: |
Thu, 22 Dec 2011 14:57:35 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Dec 22, 2011 at 02:50:27PM +0200, Avi Kivity wrote:
> On 12/22/2011 02:50 PM, Michael S. Tsirkin wrote:
> > On Mon, Dec 19, 2011 at 04:13:35PM +0200, Avi Kivity wrote:
> > > +static void vhost_log_start(MemoryListener *listener,
> > > + MemoryRegionSection *section)
> > > +{
> > > + /* FIXME: implement */
> > > +}
> > > +
> > > +static void vhost_log_stop(MemoryListener *listener,
> > > + MemoryRegionSection *section)
> > > +{
> > > + /* FIXME: implement */
> > > +}
> > > +
> >
> > What exactly do we need to fix here?
>
> Tell vhost to start tracking those regions?
>
> I guess you don't often read packets into the framebuffer, or we'd have
> a lot of bug reports.
Yes, we currently simply don't pass these regions to vhost.
It currently signals an error if such is
observed, so we could handle framebuffer in userspace
if we wanted to.
> --
> error compiling committee.c: too many arguments to function
- Re: [Qemu-devel] [PATCH 01/23] memory: introduce memory_region_find(), (continued)
- Re: [Qemu-devel] [PATCH 01/23] memory: introduce memory_region_find(), Avi Kivity, 2011/12/19
- Re: [Qemu-devel] [PATCH 01/23] memory: introduce memory_region_find(), Anthony Liguori, 2011/12/19
- Re: [Qemu-devel] [PATCH 01/23] memory: introduce memory_region_find(), Avi Kivity, 2011/12/19
- Re: [Qemu-devel] [PATCH 01/23] memory: introduce memory_region_find(), Anthony Liguori, 2011/12/19
- Re: [Qemu-devel] [PATCH 01/23] memory: introduce memory_region_find(), Avi Kivity, 2011/12/19
- Re: [Qemu-devel] [PATCH 01/23] memory: introduce memory_region_find(), Avi Kivity, 2011/12/19
[Qemu-devel] [PATCH 17/23] xen: convert to MemoryListener API, Avi Kivity, 2011/12/19
[Qemu-devel] [PATCH 14/23] vhost: convert to MemoryListener API, Avi Kivity, 2011/12/19
[Qemu-devel] [PATCH 21/23] virtio-balloon: avoid cpu_get_physical_page_desc(), Avi Kivity, 2011/12/19
[Qemu-devel] [PATCH 07/23] framebuffer: drop use of cpu_physical_sync_dirty_bitmap(), Avi Kivity, 2011/12/19
[Qemu-devel] [PATCH 02/23] sysbus: add sysbus_address_space(), Avi Kivity, 2011/12/19
[Qemu-devel] [PATCH 23/23] Remove cpu_get_physical_page_desc(), Avi Kivity, 2011/12/19
[Qemu-devel] [PATCH 22/23] sparc: avoid cpu_get_physical_page_desc(), Avi Kivity, 2011/12/19
[Qemu-devel] [PATCH 13/23] kvm: convert to MemoryListener API, Avi Kivity, 2011/12/19
[Qemu-devel] [PATCH 08/23] memory: replace cpu_physical_sync_dirty_bitmap() with a memory API, Avi Kivity, 2011/12/19
[Qemu-devel] [PATCH 18/23] memory: remove CPUPhysMemoryClient, Avi Kivity, 2011/12/19
[Qemu-devel] [PATCH 10/23] memory: add memory_region_is_logging(), Avi Kivity, 2011/12/19