[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/9pfs: Add new security model mapped-file.
From: |
Alex Bradbury |
Subject: |
Re: [Qemu-devel] [PATCH] hw/9pfs: Add new security model mapped-file. |
Date: |
Thu, 22 Dec 2011 21:45:51 +0000 |
On 19 December 2011 13:50, Aneesh Kumar K.V
<address@hidden> wrote:
> From: "Aneesh Kumar K.V" <address@hidden>
>
> This enable us to do passthrough equivalent security model on NFS directory.
> NFS server mostly do root squashing and don't support xattr. Hence we cannot
> use 'passthrough' or 'mapped' security model
>
> Also added "mapped-xattr" security to indicate earlier "mapped" security model
> Older name is still supported.
Out of interest, did you do any performance comparison with mapped-xattr?
> @@ -404,6 +578,10 @@ static int local_fstat(FsContext *fs_ctx, int fid_type,
> &tmp_dev, sizeof(dev_t)) > 0) {
> stbuf->st_rdev = tmp_dev;
> }
> +#if 0
> + } else if (fs_ctx->export_flags & V9FS_SM_MAPPED_FILE) {
> + /* FIXME!! how to implement that for MAPPED_FILE */
> +#endif
Lacking an implementation of fstat seems like a pretty major omission
that isn't mentioned in the commit message.
Alex