[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty |
Date: |
Thu, 29 Dec 2011 15:16:55 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.24) Gecko/20111108 Lightning/1.0b2 Thunderbird/3.1.16 |
>> +++ b/hw/virtio-serial-bus.c
>> @@ -163,7 +163,19 @@ static void do_flush_queued_data(VirtIOS
>> abort();
>> }
>> if (ret == -EAGAIN || (ret >= 0 && ret < buf_size)) {
>> - virtio_serial_throttle_port(port, true);
>
> I'm surprised: did you test this with upstream qemu? That codebase
> doesn't yet throttle writes, and this code path won't execute. Does
> it really not reproduce with this patch?
I think
static void handle_output(VirtIODevice *vdev, VirtQueue *vq)
[....]
if (!port->throttled) {
do_flush_queued_data(port, vq, vdev);
return;
makes a difference here, since we will never return the buffer to the guest, no?
Christian
- [Qemu-devel] [RFC] virtio-console fails on unconnected pty, Christian Borntraeger, 2011/12/15
- Re: [Qemu-devel] [RFC] virtio-console fails on unconnected pty, Amit Shah, 2011/12/16
- [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty, Christian Borntraeger, 2011/12/29
- Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty, Amit Shah, 2011/12/29
- Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty, Amit Shah, 2011/12/29
- Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty,
Christian Borntraeger <=
- Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty, Christian Borntraeger, 2011/12/29
- Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty, Amit Shah, 2011/12/29
- Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty, Christian Borntraeger, 2011/12/29
- Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty, Amit Shah, 2011/12/29
- Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty, Christian Borntraeger, 2011/12/29
- Re: [Qemu-devel] [PATCHv2] Fix virtio-console failure on unconnected pty, Amit Shah, 2011/12/29