[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 5/9] Add XBRLE to ram_save_block and ram_save
From: |
Orit Wasserman |
Subject: |
Re: [Qemu-devel] [PATCH v5 5/9] Add XBRLE to ram_save_block and ram_save_live |
Date: |
Wed, 04 Jan 2012 15:29:13 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 |
On 01/04/2012 02:14 PM, Stefan Hajnoczi wrote:
> On Tue, Jan 3, 2012 at 3:34 PM, Orit Wasserman <address@hidden> wrote:
>> + /* XOR encoding */
>> + xor_buf = (uint8_t *) g_malloc0(TARGET_PAGE_SIZE);
>
> Is this an old version of the code? I remember pointing out all the
> useless zeroing in a previous revision. If the next line is going to
> memcpy or overwrite the entire buffer, please don't zero it first -
> especially when the buffer isn't just a small struct.
I will fix it
>
> Stefan
- [Qemu-devel] [PATCH v5 2/9] Add rle_encode and rle_decode functions Implement Run Length Encoding compression, (continued)
[Qemu-devel] [PATCH v5 3/9] Add save_block_hdr function, Orit Wasserman, 2012/01/03
[Qemu-devel] [PATCH v5 5/9] Add XBRLE to ram_save_block and ram_save_live, Orit Wasserman, 2012/01/03
[Qemu-devel] [PATCH v5 9/9] Add XBRLE statistics information, Orit Wasserman, 2012/01/03
[Qemu-devel] [PATCH v5 8/9] QMP commands changes, Orit Wasserman, 2012/01/03
[Qemu-devel] [PATCH v5 6/9] Add xbrle parameters to MigrationState, Orit Wasserman, 2012/01/03
[Qemu-devel] [PATCH v5 7/9] Add set_cachesize to change XBRLE cache size, Orit Wasserman, 2012/01/03