[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 14/30] qdev: prepare source tree for code conver
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 14/30] qdev: prepare source tree for code conversion |
Date: |
Wed, 04 Jan 2012 15:07:12 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111220 Thunderbird/9.0 |
Am 03.01.2012 01:52, schrieb Anthony Liguori:
> These are various small stylistic changes which help make things more
> consistent such that the automated conversion script can be simpler.
>
> It's not necessary to agree or disagree with these style changes because all
> of this code is going to be rewritten by the patch monkey script anyway.
>
> Signed-off-by: Anthony Liguori <address@hidden>
> ---
> diff --git a/hw/es1370.c b/hw/es1370.c
> index 6a3ba55..3527eb6 100644
> --- a/hw/es1370.c
> +++ b/hw/es1370.c
> @@ -1041,13 +1041,8 @@ static PCIDeviceInfo es1370_info = {
> .vendor_id = PCI_VENDOR_ID_ENSONIQ,
> .device_id = PCI_DEVICE_ID_ENSONIQ_ES1370,
> .class_id = PCI_CLASS_MULTIMEDIA_AUDIO,
> -#if 1
> .subsystem_vendor_id = 0x4942,
> .subsystem_id = 0x4c4c,
> -#else
> - .subsystem_vendor_id = 0x1274,
> - .subsystem_id = 0x1371,
> -#endif
> };
>
> static void es1370_register (void)
It is worth noting that this is *not* a stylistic change but actually
dropping device information from the tree.
malc, what is the meaning of the currently unused values? Would it make
sense to move them to a separate PCIDeviceInfo so that they survive the
QOM introduction?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- Re: [Qemu-devel] [PATCH 03/30] ppc: remove ppc440 bamboo board support, (continued)
- Re: [Qemu-devel] [PATCH 03/30] ppc: remove ppc440 bamboo board support, Andreas Färber, 2012/01/13
- Re: [Qemu-devel] [PATCH 03/30] ppc: remove ppc440 bamboo board support, Paolo Bonzini, 2012/01/13
- Re: [Qemu-devel] [PATCH 03/30] ppc: remove ppc440 bamboo board support, Alexander Graf, 2012/01/13
- Re: [Qemu-devel] [PATCH 03/30] ppc: remove ppc440 bamboo board support, Andreas Färber, 2012/01/13
- Re: [Qemu-devel] [PATCH 03/30] ppc: remove ppc440 bamboo board support, Alexander Graf, 2012/01/13
[Qemu-devel] [PATCH 08/30] qdev: integrate with QEMU Object Model (v2), Anthony Liguori, 2012/01/02
[Qemu-devel] [PATCH 13/30] qdev: add class_init to DeviceInfo, Anthony Liguori, 2012/01/02
[Qemu-devel] [PATCH 07/30] qom: add the base Object class (v2), Anthony Liguori, 2012/01/02
[Qemu-devel] [PATCH 14/30] qdev: prepare source tree for code conversion, Anthony Liguori, 2012/01/02
- Re: [Qemu-devel] [PATCH 14/30] qdev: prepare source tree for code conversion,
Andreas Färber <=
[Qemu-devel] [PATCH 06/30] pci: call reset unconditionally, Anthony Liguori, 2012/01/02
[Qemu-devel] [PATCH 04/30] ppc_prep: convert host bridge to qdev, Anthony Liguori, 2012/01/02
[Qemu-devel] [PATCH 09/30] qdev: move qdev->info to class, Anthony Liguori, 2012/01/02
[Qemu-devel] [PATCH 11/30] qdev: use a wrapper to access reset and promote reset to a class method, Anthony Liguori, 2012/01/02
[Qemu-devel] [PATCH 10/30] qdev: don't access name through info, Anthony Liguori, 2012/01/02