[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 9/9] qemu-nbd: drop loop which can never loop
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 9/9] qemu-nbd: drop loop which can never loop |
Date: |
Fri, 6 Jan 2012 15:51:28 +0000 |
For some reason nbd_client_thread() has a do..while loop which can never
loop, the condition is bogus because we would take a goto instead. Drop
the loop.
Reported-by: Dr David Alan Gilbert <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
qemu-nbd.c | 10 ++++------
1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index 155b058..eb61c33 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -202,12 +202,10 @@ static void *nbd_client_thread(void *arg)
int ret;
pthread_t show_parts_thread;
- do {
- sock = unix_socket_outgoing(sockpath);
- if (sock == -1) {
- goto out;
- }
- } while (sock == -1);
+ sock = unix_socket_outgoing(sockpath);
+ if (sock == -1) {
+ goto out;
+ }
ret = nbd_receive_negotiate(sock, NULL, &nbdflags,
&size, &blocksize);
--
1.7.7.3
- [Qemu-devel] [PULL 0/9] Trivial patches for 20 December 2011 to 6 January 2012, Stefan Hajnoczi, 2012/01/06
- [Qemu-devel] [PATCH 5/9] configure: Fix test for supported host CPU type, Stefan Hajnoczi, 2012/01/06
- [Qemu-devel] [PATCH 3/9] scsi virtio-blk usb-msd: Clean up device init error messages, Stefan Hajnoczi, 2012/01/06
- [Qemu-devel] [PATCH 7/9] net/socket.c: Fix fd leak in net_socket_listen_init() error paths, Stefan Hajnoczi, 2012/01/06
- [Qemu-devel] [PATCH 2/9] Strip trailing '\n' from error_report()'s first argument (again), Stefan Hajnoczi, 2012/01/06
- [Qemu-devel] [PATCH 8/9] Make python mandatory, Stefan Hajnoczi, 2012/01/06
- [Qemu-devel] [PATCH 6/9] gdbstub: Fix fd leak in gdbserver_open() error path, Stefan Hajnoczi, 2012/01/06
- [Qemu-devel] [PATCH 1/9] qemu-options.hx: fix tls-channel help text, Stefan Hajnoczi, 2012/01/06
- [Qemu-devel] [PATCH 4/9] configure: CONFIG_QEMU_INTERP_PREFIX only for user mode, Stefan Hajnoczi, 2012/01/06
- [Qemu-devel] [PATCH 9/9] qemu-nbd: drop loop which can never loop,
Stefan Hajnoczi <=
- Re: [Qemu-devel] [PULL 0/9] Trivial patches for 20 December 2011 to 6 January 2012, Anthony Liguori, 2012/01/09