[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] sm501: Fix size of color_reg
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH] sm501: Fix size of color_reg |
Date: |
Sat, 7 Jan 2012 21:29:44 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Jan 04, 2012 at 10:50:09PM +0100, Stefan Weil wrote:
> color_reg is expected to hold 32 bit values, so it was too small.
>
> This bug was reported by coverity:
>
> hw/sm501.c:624:
> result_independent_of_operands:
> color_reg >> 16 is 0 regardless of the values of its operands.
> This occurs as the bitwise first operand of '&'.
>
> Cc: Shin-ichiro Kawasaki <address@hidden>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
> hw/sm501.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
Thanks, applied.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net