Re: [Qemu-devel] [PATCH 11/11] check: add a check-report and check-help target

[Andreas Färber]

Am 09.01.2012 16:56, schrieb Anthony Liguori:
> Signed-off-by: Anthony Liguori <address@hidden>
> ---
>  tests/Makefile |   43 ++++++++++++++++++++++++++++++++++++++++---
>  1 files changed, 40 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/Makefile b/tests/Makefile
> index cba482f..7228f44 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -33,6 +33,43 @@ test-qmp-input-visitor: test-qmp-input-visitor.o 
> $(qobject-obj-y) $(qapi-obj-y)
>  test-qmp-commands.o: $(addprefix $(qapi-dir)/, test-qapi-types.c 
> test-qapi-types.h test-qapi-visit.c test-qapi-visit.h test-qmp-marshal.c 
> test-qmp-commands.h) $(qapi-obj-y)
>  test-qmp-commands: test-qmp-commands.o $(qobject-obj-y) $(qapi-obj-y) 
> $(tools-obj-y) $(qapi-dir)/test-qapi-visit.o $(qapi-dir)/test-qapi-types.o 
> $(qapi-dir)/test-qmp-marshal.o module.o
>  
> -.PHONY: check
> -check: $(CHECKS)
> -     gtester $(CHECKS)
> +check: check-quick
> +
> +check-slow: $(CHECKS)
> +     gtester -m=slow $(CHECKS)
> +
> +check-quick: $(CHECKS)
> +     gtester -m=quick $(CHECKS)
> +
> +check-perf: $(CHECKS)
> +     gtester -m=perf $(CHECKS)
> +
> +check-help:
> +     @echo "Regression targets:"
> +     @echo
> +     @echo " make check                Alias for 'make check-quick'"
> +     @echo " make check-quick          Run all unit tests in 'quick' mode"
> +     @echo " make check-slow           Run all unit tests in 'slow' mode"
> +     @echo " make check-perf           Run all unit tests in 'perf' mode"

Are these a fixed set of profiles defined by gtester, or are they
arbitrary choices?

quick and slow seem intuitive but 'perf' could use an explanation:
Is 'perf' more performant than quick, or does it measure performance?
(or is it for perfidious test cases?;))

If test cases need to be annotated as slow, describe it in the commit
message?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg