Re: [Qemu-devel] [PATCH] tracetool: Omit useless QEMU_*_ENABLED() check

[Stefan Hajnoczi]

On Tue, Sep 27, 2011 at 9:00 AM, Stefan Hajnoczi
<address@hidden> wrote:
> SystemTap provides a "semaphore" that can optionally be tested before
> executing a trace event.  The purpose of this mechanism is to skip
> expensive tracing code when the trace event is disabled.
>
> For example, some applications may have trace events that format or
> convert strings for trace events.  This expensive processing should only
> be done in the case where the trace event is enabled.
>
> Since QEMU's generated trace events never have such special-purpose
> code, there is no reason to add the semaphore check.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
>  scripts/tracetool |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)

Oops, this never got merged.  I have added it to my tracing queue and
it will be part of the next pull request:
https://github.com/stefanha/qemu/tree/tracing

Stefan