[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 04/15] block: add image streaming block job
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v4 04/15] block: add image streaming block job |
Date: |
Thu, 12 Jan 2012 09:11:32 +0000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Jan 11, 2012 at 03:18:28PM -0200, Luiz Capitulino wrote:
> On Fri, 6 Jan 2012 14:01:30 +0000
> Stefan Hajnoczi <address@hidden> wrote:
> > +int stream_start(BlockDriverState *bs, BlockDriverState *base,
> > + BlockDriverCompletionFunc *cb, void *opaque)
> > +{
> > + StreamBlockJob *s;
> > + Coroutine *co;
> > +
> > + if (bs->job) {
> > + return -EBUSY;
> > + }
> > +
> > + s = block_job_create(&stream_job_type, bs, cb, opaque);
> > + s->base = base;
>
> This is missing a check against NULL.
Good catch.
- [Qemu-devel] [PATCH v4 00/15] block: generic image streaming, Stefan Hajnoczi, 2012/01/06
- [Qemu-devel] [PATCH v4 02/15] block: check bdrv_in_use() before blockdev operations, Stefan Hajnoczi, 2012/01/06
- [Qemu-devel] [PATCH v4 03/15] block: add BlockJob interface for long-running operations, Stefan Hajnoczi, 2012/01/06
- [Qemu-devel] [PATCH v4 07/15] qmp: add block_job_set_speed command, Stefan Hajnoczi, 2012/01/06
- [Qemu-devel] [PATCH v4 06/15] qmp: add block_stream command, Stefan Hajnoczi, 2012/01/06
- [Qemu-devel] [PATCH v4 04/15] block: add image streaming block job, Stefan Hajnoczi, 2012/01/06
[Qemu-devel] [PATCH v4 10/15] blockdev: make image streaming safe across hotplug, Stefan Hajnoczi, 2012/01/06
[Qemu-devel] [PATCH v4 05/15] block: rate-limit streaming operations, Stefan Hajnoczi, 2012/01/06
[Qemu-devel] [PATCH v4 09/15] qmp: add query-block-jobs, Stefan Hajnoczi, 2012/01/06
[Qemu-devel] [PATCH v4 08/15] qmp: add block_job_cancel command, Stefan Hajnoczi, 2012/01/06