qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH][v9] megasas: LSI Megaraid SAS HBA emulation


From: Hannes Reinecke
Subject: Re: [Qemu-devel] [PATCH][v9] megasas: LSI Megaraid SAS HBA emulation
Date: Mon, 16 Jan 2012 08:18:45 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.14) Gecko/20110221 SUSE/3.1.8 Thunderbird/3.1.8

On 01/15/2012 10:21 AM, Avi Kivity wrote:
> On 01/13/2012 06:54 PM, Andreas Färber wrote:
>>> +static void megasas_unmap_sgl(struct megasas_cmd_t *cmd)
>>> +{
>>> +    int i, is_write = megasas_frame_is_write(cmd);
>>> +
>>> +    for (i = 0; i < cmd->iov_cnt; i++) {
>>> +        cpu_physical_memory_unmap(cmd->iov[i].iov_base, 
>>> cmd->iov[i].iov_len,
>>> +                                  is_write, cmd->iov[i].iov_len);
>>
>> Not sure, but cpu_physical_memory_* sounds old-fashioned. Might need an
>> update to MemoryRegion?
> 
> These APIs have not been updated (yet?).
> 
That's what I thought.

Plus even virtio is using it, so I'd be very much interested in the
argument why megasas can't use it ...

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                   zSeries & Storage
address@hidden                        +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]