[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 04/10] fdc: emulate stepping 0
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v2 04/10] fdc: emulate stepping 0 |
Date: |
Mon, 16 Jan 2012 10:54:27 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 |
Am 15.01.2012 08:51, schrieb Hervé Poussineau:
> Stepping 1 (S82078B) is not fully i82078 compatible, so better stick to
> initial revision
>
> Signed-off-by: Hervé Poussineau <address@hidden>
> ---
> hw/fdc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/fdc.c b/hw/fdc.c
> index bedaeca..0e167f8 100644
> --- a/hw/fdc.c
> +++ b/hw/fdc.c
> @@ -1385,7 +1385,7 @@ static void fdctrl_handle_version(FDCtrl *fdctrl, int
> direction)
>
> static void fdctrl_handle_partid(FDCtrl *fdctrl, int direction)
> {
> - fdctrl->fifo[0] = 0x41; /* Stepping 1 */
> + fdctrl->fifo[0] = 0x01; /* Stepping 0 */
> fdctrl_set_fifo(fdctrl, 1, 0);
> }
>
Hm, this is the kind of change that I'm hesitant to make because I don't
understand the implications. Can you give some more details what is
fixed by this and why you think it's harmless for currently working OSes?
My spec says this:
6 3 14 PART ID COMMAND
This command can be used to identify the floppy
disk controller as an enhanced controller The first
stepping of the 82078 (all 44 pin versions) will yield
0x41 in the result phase of this command Any future
enhancements on these parts will be denoted by the
5 LSBs (0x01 to 0x1F)
It doesn't even define what 0x01 would mean.
Kevin
- [Qemu-devel] [PATCH v2 00/10] Misc fixes for floppy emulation, Hervé Poussineau, 2012/01/15
- [Qemu-devel] [PATCH v2 01/10] fdc: take side count into account, Hervé Poussineau, 2012/01/15
- [Qemu-devel] [PATCH v2 03/10] fdc: most control commands do not generate interrupts, Hervé Poussineau, 2012/01/15
- [Qemu-devel] [PATCH v2 02/10] fdc: set busy bit when starting a command, Hervé Poussineau, 2012/01/15
- [Qemu-devel] [PATCH v2 05/10] fdc: handle read-only floppies (abort early on write commands), Hervé Poussineau, 2012/01/15
- [Qemu-devel] [PATCH v2 06/10] fdc: add CCR (Configuration Control Register) write register, Hervé Poussineau, 2012/01/15
- [Qemu-devel] [PATCH v2 04/10] fdc: emulate stepping 0, Hervé Poussineau, 2012/01/15
- Re: [Qemu-devel] [PATCH v2 04/10] fdc: emulate stepping 0,
Kevin Wolf <=
- [Qemu-devel] [PATCH v2 07/10] block: add a transfer rate for floppy types, Hervé Poussineau, 2012/01/15
[Qemu-devel] [PATCH v2 10/10] fdc: DIR (Digital Input Register) should return status of current drive..., Hervé Poussineau, 2012/01/15
[Qemu-devel] [PATCH v2 08/10] fdc: check if media rate is correct before doing any transfer, Hervé Poussineau, 2012/01/15
[Qemu-devel] [PATCH v2 09/10] fdc: fix seek command, which shouldn't check tracks, Hervé Poussineau, 2012/01/15