[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/14] softfloat: Fix mixups of int and int16
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 04/14] softfloat: Fix mixups of int and int16 |
Date: |
Mon, 16 Jan 2012 17:51:39 +0000 |
On 16 January 2012 00:46, Andreas Färber <address@hidden> wrote:
> normalizeFloat{32,64}Subnormal() expect the exponent as int16, not int.
> This went unnoticed since int16 and uint16 were both typedef'ed to int.
I think at the time I wrote that I was being slightly conservative
because I didn't feel like confirming that we wouldn't overflow a
16 bit type.
Anyway, I have tested this patch:
* in combination with your others
* with typedefs set up so all int16 &co are the minimum width they
could be
* with typedefs so int16 &co are all 64 bits wide
and this all still gives the right results for ARM vfm, so
Reviewed-by: Peter Maydell <address@hidden>
-- PMM
- Re: [Qemu-devel] [PATCH 01/14] lm32: Fix mixup of uint32 and uint32_t, (continued)
[Qemu-devel] [PATCH 06/14] softfloat: Replace uint16 type with uint_fast16_t, Andreas Färber, 2012/01/15
[Qemu-devel] [PATCH 04/14] softfloat: Fix mixups of int and int16, Andreas Färber, 2012/01/15
- Re: [Qemu-devel] [PATCH 04/14] softfloat: Fix mixups of int and int16,
Peter Maydell <=
[Qemu-devel] [PATCH 03/14] qemu-tool: Fix mixup of int64 and int64_t, Andreas Färber, 2012/01/15
[Qemu-devel] [PATCH 09/14] softfloat: Replace int8 type with int_fast8_t, Andreas Färber, 2012/01/15
[Qemu-devel] [PATCH 08/14] softfloat: Remove unused uint8 type, Andreas Färber, 2012/01/15
[Qemu-devel] [PATCH 12/14] softfloat: Replace uint64 type with uint_fast64_t, Andreas Färber, 2012/01/15
[Qemu-devel] [PATCH 11/14] softfloat: Replace int32 type with int_fast32_t, Andreas Färber, 2012/01/15
[Qemu-devel] [PATCH 10/14] softfloat: Replace uint32 type with uint_fast32_t, Andreas Färber, 2012/01/15
[Qemu-devel] [PATCH 07/14] softfloat: Replace int16 type with int_fast16_t, Andreas Färber, 2012/01/15
[Qemu-devel] [PATCH 14/14] softfloat: Replace flag type with bool, Andreas Färber, 2012/01/15