qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 04/14] softfloat: Fix mixups of int and int16


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 04/14] softfloat: Fix mixups of int and int16
Date: Mon, 16 Jan 2012 17:51:39 +0000

On 16 January 2012 00:46, Andreas Färber <address@hidden> wrote:
> normalizeFloat{32,64}Subnormal() expect the exponent as int16, not int.
> This went unnoticed since int16 and uint16 were both typedef'ed to int.

I think at the time I wrote that I was being slightly conservative
because I didn't feel like confirming that we wouldn't overflow a
16 bit type.

Anyway, I have tested this patch:
 * in combination with your others
 * with typedefs set up so all int16 &co are the minimum width they
   could be
 * with typedefs so int16 &co are all 64 bits wide

and this all still gives the right results for ARM vfm, so

Reviewed-by: Peter Maydell <address@hidden>

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]