[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI |
Date: |
Wed, 25 Jan 2012 15:53:06 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0 |
On 01/25/2012 03:39 PM, Ronnie Sahlberg wrote:
> This patch adds configuration variables for iSCSI to set
> initiator-name to use when logging in to the target,
> which type of header-digest to negotiate with the target
> and username and password for CHAP authentication.
>
> This allows specifying a initiator-name either from the command line
> -iscsi initiator-name=iqn.2004-01.com.example:test
> or from a configuration file included with -readconfig
> [iscsi]
> initiator-name = iqn.2004-01.com.example:test
> header-digest = CRC32C|CRC32C-NONE|NONE-CRC32C|NONE
> user = CHAP username
> password = CHAP password
>
> If you use several different targets, you can also configure this on a per
> target basis by using a group name:
> [iscsi "iqn.target.name"]
> ...
>
> The configuration file can be read using -readconfig.
> Example :
> qemu-system-i386 -drive file=iscsi://127.0.0.1/iqn.ronnie.test/1
> -readconfig iscsi.conf
>
> Signed-off-by: Ronnie Sahlberg <address@hidden>
> ---
> block/iscsi.c | 139
> +++++++++++++++++++++++++++++++++++++++++++++++++++----
> qemu-config.c | 27 +++++++++++
> qemu-doc.texi | 54 +++++++++++++++++++++-
> qemu-options.hx | 16 +++++--
> vl.c | 8 +++
> 5 files changed, 229 insertions(+), 15 deletions(-)
I don't know the qemu code base well enough to give a full ack, but I
can at least state that you addressed my concerns from v1. Thanks!
> +++ b/qemu-doc.texi
> @@ -730,6 +730,57 @@ export LIBISCSI_CHAP_PASSWORD=<password>
> +
> +
> +Howto use a configuration file to set iSCSI configuration options:
s/Howto/How to/
> address@hidden
> +cat >iscsi.conf <<EOF
> +[iscsi]
> + user = "me"
> + password = "my password"
> + initiator-name = "iqn.qemu.test:my-initiator"
> + header-digest = "CRC32C"
> +EOF
> +
> +qemu-system-i386 -drive file=iscsi://127.0.0.1/iqn.qemu.test/1 \
> + -readconfig iscsi.conf
> address@hidden example
> +
> +
> Howto set up a simple iSCSI target on loopback and accessing it via QEMU:
then again, you were copying and pasting.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature