[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] scsi: Guard against buflen exceeding req->cmd.x
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH] scsi: Guard against buflen exceeding req->cmd.xfer in scsi_disk_emulate_command |
|
Date: |
Thu, 26 Jan 2012 11:41:38 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0 |
Am 26.01.2012 08:50, schrieb Paolo Bonzini:
> On 01/24/2012 06:19 PM, Thomas Higdon wrote:
>> I agree that it's better to get this into a more general place. However,
>> I wasn't willing to pull the MIN statement up into scsi_send_command
>> because I don't understand the interplay between 'len' in that function
>> and r->iov.iov_len. I couldn't see that there was a general relationship
>> between these two variables that applied to both read/write commands and
>> other commands.
>
> That's good enough, and it should fix also the bugs with GET
> CONFIGURATION that Artyom reported. Two birds with a stone!
>
> Reviewed-by: Paolo Bonzini <address@hidden>
>
> Kevin, shall I take this patch in the virtio-scsi series? I'll have to
> resubmit anyway due to the QOM changes.
I have picked it up for the block branch. If it conflicts with your
changes, you can just rebase on top of that.
Kevin