qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 01/15] pc: merge pc_piix.c into pc.c


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 01/15] pc: merge pc_piix.c into pc.c
Date: Thu, 26 Jan 2012 13:40:48 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110922 Lightning/1.0b2 Thunderbird/3.1.15

On 01/26/2012 01:00 PM, Anthony Liguori wrote:
A long time ago, there was a grand plan to merge q35 chipset support.  The start
of that series was a refactoring of pc.c which split a bunch of the "common"
functionality into a separate file that could be shared by the two.

But q35 never got merged and the refactoring, in retrospect, just made things
worse.  Making things proper objects and using composition is the right way
to share common devices.

By pulling these files back together, we can start to fix some of this mess.

Signed-off-by: Anthony Liguori<address@hidden>

BTW, the whole series is also available at:

https://github.com/aliguori/qemu/tree/qom-rebase.10

If you just want to skip ahead to the good stuff, look at:

https://github.com/aliguori/qemu/blob/qom-rebase.10/hw/piix_pci.c#L384

Compared to:

http://git.qemu.org/?p=qemu.git;a=blob;f=hw/piix_pci.c;h=3652522e58f0bbed35d687013af9978bdb4901f7;hb=HEAD#l252

Regards,

Anthony Liguori




reply via email to

[Prev in Thread] Current Thread [Next in Thread]