Re: [Qemu-devel] [PATCH 14/15] i440fx: move bios loading to i440fx

[Jan Kiszka]

On 2012-01-31 15:57, Anthony Liguori wrote:
> On 01/31/2012 08:53 AM, Jan Kiszka wrote:
>> On 2012-01-31 15:50, Anthony Liguori wrote:
>>> On 01/31/2012 08:38 AM, Jan Kiszka wrote:
>>>> On 2012-01-26 20:00, Anthony Liguori wrote:
>>>>> ---
>>>>>    hw/pc.c       |   70 
>>>>> ++++--------------------------------------------------
>>>>>    hw/pc.h       |    3 +-
>>>>>    hw/piix_pci.c |   74 
>>>>> +++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>>>>>    sysemu.h      |    2 -
>>>>>    4 files changed, 79 insertions(+), 70 deletions(-)
>>>>
>>>> How does the ISA PC get its BIOS after this change? Or did that change
>>>> in a step I miss right now?
>>>
>>> Oh, I broke it.  I made no attempt to keep ISA PC working.
>>>
>>> The way I'd like to handle this is to introduce a ROM device so that this 
>>> code
>>> would be trivialized.
>>
>> Or just keep the common pc.c library as I voted for. It has its purpose,
>> obviously.
> 
> Coding sharing needs to happen through device sharing.  Otherwise we'll be 
> stuck 
> in the magic device creation through arbitrary functions rut that we 
> currently 
> find ourselves in.

Well, let's see what this will mean in practice. I'm sure that that
there are steps in a PC construction that cannot be modeled reasonable
even as pseudo devices but at still shared among boards.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux