qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC v2 4/8] qom: Introduce CPU class


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH RFC v2 4/8] qom: Introduce CPU class
Date: Wed, 1 Feb 2012 22:25:53 +0000

On 1 February 2012 12:57, Andreas Färber <address@hidden> wrote:
> It's abstract and derived directly from TYPE_OBJECT.
> Prepare a virtual reset method.
>
> Place it in hw/. Have user emulators pick it up via VPATH, building it
> per target since they didn't use any qdev/QOM devices so far.

>  ifdef CONFIG_LINUX_USER
>
> -$(call set-vpath, 
> $(SRC_PATH)/linux-user:$(SRC_PATH)/linux-user/$(TARGET_ABI_DIR))
> +$(call set-vpath, 
> $(SRC_PATH)/linux-user:$(SRC_PATH)/linux-user/$(TARGET_ABI_DIR):$(SRC_PATH)/hw)

I don't think we should go down the path of adding hw/ to the vpath
path for the user-mode emulators. hw/ is for system emulator specific
code and I don't think we should change that.

On the other hand I don't have an immediate answer to where it
should go instead and we didn't seem to come up with a clear answer
on IRC either. Anthony seems to be suggesting that as we do "proper"
QOM conversions on devices we move them out of hw/, I think, in
which case maybe we should put this in wherever the new right
place is (under some new subdir of qom/ ?)

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]