[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 0/1] Allow the building of VirtFS to be disab
From: |
Meador Inge |
Subject: |
Re: [Qemu-devel] [PATCH v1 0/1] Allow the building of VirtFS to be disabled |
Date: |
Thu, 9 Feb 2012 16:25:13 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0 |
On 02/08/2012 02:15 AM, Aneesh Kumar K.V wrote:
> On Tue, 7 Feb 2012 14:44:05 -0600, Meador Inge <address@hidden> wrote:
>> There have been reports [1, 2] where folks have had issues building
>> VirtFS and the virtio backend on older systems. I personally saw
>> problems due to the use of features (struct statfs f_frsize field,
>> fdopendir, O_NOATIME) in this code that are not available on much older
>> Linux systems. Given, the system I ran into this on is ancient (RH8
>> sysroot),
>> but I still need to build QEMU on it nonetheless.
>>
>> This patch adds a new configure option for disabling the building of
>> VirtFS all together. Tested by building with and without --disable-virtfs
>> on older (RH8 sysroot) and newer systems (x64 Fedora 16).
>>
>> [1] http://lists.nongnu.org/archive/html/qemu-devel/2011-12/msg00171.html
>> [2] http://lists.nongnu.org/archive/html/qemu-devel/2012-02/msg00404.html
>>
>> Meador Inge (1):
>> ./configure: add option for disabling VirtFS
>>
>> Makefile | 4 ++++
>> configure | 16 +++++++++++++---
>> 2 files changed, 17 insertions(+), 3 deletions(-)
>
> I like the patch because it help to get qemu build on platforms where
> the build failures are only due to virtfs. VirtFS do depend on some of
> the recent linux APIs, so sometime we do break build on old Linux
> distros.
Great. Thanks for the review. Can someone commit this for me?
> Anthony any objection here ?
>
> -aneesh
>
--
Meador Inge
CodeSourcery / Mentor Embedded
http://www.mentor.com/embedded-software