qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC][PATCH 03/16 v6] Add API to check whether a physic


From: Jan Kiszka
Subject: Re: [Qemu-devel] [RFC][PATCH 03/16 v6] Add API to check whether a physical address is I/O address
Date: Tue, 14 Feb 2012 17:52:49 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666

On 2012-02-09 04:21, Wen Congyang wrote:
> This API will be used in the following patch.
> 
> Signed-off-by: Wen Congyang <address@hidden>
> ---
>  cpu-common.h |    2 ++
>  exec.c       |   16 ++++++++++++++++
>  2 files changed, 18 insertions(+), 0 deletions(-)
> 
> diff --git a/cpu-common.h b/cpu-common.h
> index a40c57d..d047137 100644
> --- a/cpu-common.h
> +++ b/cpu-common.h
> @@ -71,6 +71,8 @@ void cpu_physical_memory_unmap(void *buffer, 
> target_phys_addr_t len,
>  void *cpu_register_map_client(void *opaque, void (*callback)(void *opaque));
>  void cpu_unregister_map_client(void *cookie);
>  
> +bool is_io_addr(target_phys_addr_t phys_addr);

Something like cpu_physical_memory_is_io would be more consistent with
other APIs around.

> +
>  /* Coalesced MMIO regions are areas where write operations can be reordered.
>   * This usually implies that write operations are side-effect free.  This 
> allows
>   * batching which can make a major impact on performance when using
> diff --git a/exec.c b/exec.c
> index b81677a..edc5684 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -4435,3 +4435,19 @@ bool virtio_is_big_endian(void)
>  #undef env
>  
>  #endif
> +
> +bool is_io_addr(target_phys_addr_t phys_addr)
> +{
> +    ram_addr_t pd;
> +    PhysPageDesc p;
> +
> +    p = phys_page_find(phys_addr >> TARGET_PAGE_BITS);
> +    pd = p.phys_offset;
> +
> +    if (!is_ram_rom_romd(pd)) {

return !is_ram_rom_romd(pd); ?

> +        /* I/O region */
> +        return true;
> +    }
> +
> +    return false;
> +}

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux



reply via email to

[Prev in Thread] Current Thread [Next in Thread]