[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC][PATCH 16/16 v6] allow user to dump a fraction of
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [RFC][PATCH 16/16 v6] allow user to dump a fraction of the memory |
Date: |
Tue, 14 Feb 2012 19:27:46 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-02-09 04:34, Wen Congyang wrote:
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index a026905..388b9ac 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -868,9 +868,11 @@ ETEXI
>
> {
> .name = "dump",
> - .args_type = "detach:-d,file:s",
> + .args_type = "detach:-d,file:s,begin:i?,length:i?",
> .params = "file",
You forgot to update params.
> - .help = "dump to file (using -d to not wait for completion)",
> + .help = "dump to file (using -d to not wait for completion)"
> + "\n\t\t\t begin(optional): the starting physical
> address"
> + "\n\t\t\t length(optional): the memory size, in bytes",
Is it [begin [lenght]] or [begin lenght]? If you specify params, you
don't need to state optional here.
Same for QMP.
I'm short on time, thus didn't look at code in patches >= 10.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
- Re: [Qemu-devel] [RFC][PATCH 09/16 v6] introduce a new monitor command 'dump' to dump guest's memory, (continued)
- [Qemu-devel] [RFC][PATCH 10/16 v6] run dump at the background, Wen Congyang, 2012/02/08
- [Qemu-devel] [RFC][PATCH 11/16 v6] support detached dump, Wen Congyang, 2012/02/08
- [Qemu-devel] [RFC][PATCH 12/16 v6] support to cancel the current dumping, Wen Congyang, 2012/02/08
- [Qemu-devel] [RFC][PATCH 13/16 v6] support to set dumping speed, Wen Congyang, 2012/02/08
- [Qemu-devel] [RFC][PATCH 14/16 v6] support to query dumping status, Wen Congyang, 2012/02/08
- [Qemu-devel] [RFC][PATCH 15/16 v6] auto cancel dumping after vm state is changed to run, Wen Congyang, 2012/02/08
- [Qemu-devel] [RFC][PATCH 16/16 v6] allow user to dump a fraction of the memory, Wen Congyang, 2012/02/08
- Re: [Qemu-devel] [RFC][PATCH 16/16 v6] allow user to dump a fraction of the memory,
Jan Kiszka <=
- Re: [Qemu-devel] [RFC][PATCH 00/16 v6] introducing a new, dedicated memory dump mechanism, Wen Congyang, 2012/02/12