Re: [Qemu-devel] [PATCH v2 1/1] exec: Fix watchpoint implementation

[Andreas Färber]

Am 17.02.2012 18:03, schrieb Meador Inge:
> Fix a bug introduced by commit 1ec9b909ff207a44d5ef2609cb4a2e3d449d485f
> where 'watch_mem_write' was modified to fall-through to 'abort' on
> every input.
> 
> Signed-off-by: Meador Inge <address@hidden>

Reviewed-by: Andreas Färber <address@hidden>

Andreas

> ---
> * Changes since v1:
>   - 'break' out of switch statement instead of 'return'.
>  exec.c |   12 +++++++++---
>  1 files changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/exec.c b/exec.c
> index b81677a..f105b43 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -3289,9 +3289,15 @@ static void watch_mem_write(void *opaque, 
> target_phys_addr_t addr,
>  {
>      check_watchpoint(addr & ~TARGET_PAGE_MASK, ~(size - 1), BP_MEM_WRITE);
>      switch (size) {
> -    case 1: stb_phys(addr, val);
> -    case 2: stw_phys(addr, val);
> -    case 4: stl_phys(addr, val);
> +    case 1:
> +        stb_phys(addr, val);
> +        break;
> +    case 2:
> +        stw_phys(addr, val);
> +        break;
> +    case 4:
> +        stl_phys(addr, val);
> +        break;
>      default: abort();
>      }
>  }

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg