Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev

[Andreas Färber]

Am 17.02.2012 18:16, schrieb Igor Mammedov:
> On 02/16/2012 05:09 PM, Andreas Färber wrote:
>> We should have a single code path through which we instantiate
>> CPUs, currently: cpu_$arch_init(const char *cpu_model)
>> With my series completed, this would return an X86CPU object.
>>
>> Depending on our liking, we could either place some ICC / APIC /
>> whatever fields directly into that, or embed the X86CPU in an object
>> such as yours above as a link<X86CPU>. I do feel however that the model
>> string is misplaced there. Question is whether this ICC stuff is
>> actually part of the CPU or part of the CPU wiring on the mainboard - I
>> vaguely remember someone saying that this changed over time...? Having
> Yep, since P4 times sysbus used instead of icc so we can just ignore icc.
> 
>> both depending on CPU subclass might also be an option, but I'd rather
>> leave such decisions as a follow-up to the core QOM'ification.
>>
> 
> With QOM and your work this patch is obsolete. I see you've already
> QOM-ified X86CPU in your qom-cpu tree.

Yeah, I postponed PowerPC and took a shortcut by renaming cpuid.c. ;)

> With your permission I'll play with it and
> check
> what could be done for cpu hot-plug feature.

Sure, just beware that I frequently rebase this branch based on feedback
or moving upstream.
Also note that the CPUArchState refactoring is meant only temporary (I'm
using a script for that) and should be avoided in new code in favor of
CPUX86State or X86CPU/X86CPUClass.

If you need some change to make your hotplug work easier, just let me know.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg