[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [patch] qemu-1.0.1/VERSION
From: |
Justin M. Forbes |
Subject: |
Re: [Qemu-devel] [patch] qemu-1.0.1/VERSION |
Date: |
Sun, 19 Feb 2012 16:26:14 -0600 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sun, Feb 19, 2012 at 11:51:25AM +0100, Stefan Weil wrote:
> Am 19.02.2012 01:05, schrieb Kenneth Salerno:
> >Hello,
> >
> >The VERSION file in stable release qemu-1.0.1 has what I believe might be a
> >typo: "1.0,1" rather than "1.0.1". This is causing a parsing issue for
> >windres.exe in Win32 which chokes on:
> > #define CONFIG_FILEVERSION 1,0,1,0,1,0
> > #define CONFIG_PRODUCTVERSION 1,0,1,0,1,0
> >
> >when it should be seeing this:
> > #define CONFIG_FILEVERSION 1,0,1,0
> > #define CONFIG_PRODUCTVERSION 1,0,1,0
> >
> >
> >Patch:
> >--- VERSION.ORIG 2012-02-18 18:56:16.625000000 -0500
> >+++ VERSION 2012-02-18 18:56:31.609375000 -0500
> >@@ -1 +1 @@
> >-1.0,1
> >+1.0.1
>
> Acked-by: Stefan Weil <address@hidden>
Ack, wow do I feel silly. Thanks for the catch.
--
Justin M. Forbes