Re: [Qemu-devel] [PATCHv2-RFC 2/2] pci: add standard bridge device

[Michael S. Tsirkin]

On Sun, Feb 19, 2012 at 04:57:07PM +0200, Michael S. Tsirkin wrote:
> On Fri, Feb 17, 2012 at 02:25:56PM +0100, Gerd Hoffmann wrote:
> >   Hi,
> > 
> > > +    /* If we don't specify the name, the bus will be addressed as 
> > > <id>.0, where
> > > +     * id is the parent id.  But it seems more natural to address the 
> > > bus using
> > > +     * the parent device name. */
> > > +    if (dev->qdev.id && *dev->qdev.id) {
> > > +        br->bus_name = dev->qdev.id;
> > > +    }
> > 
> > That makes the bridge behave different than everybody else.
> > Not a good idea IMHO.
> > 
> > cheers,
> >   Gerd
> 
> Everybody else has names built up according to an undocumented scheme
> which no one can figure out without reading code, so no one uses them.
> We need to fix that, but there is, generally, no need for these names
> so it stayed low priority.
> 
> With the bridge people must use the id to connect devices to it,
> so name must be a sane one.

I just sent the patch making bus id for bridges
follow the value set by the user.
That will make the bridge behave in the same way
as everybody else :)

> -- 
> MST