qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/5] block: Don't call bdrv_eject() if the tray


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 3/5] block: Don't call bdrv_eject() if the tray state didn't change
Date: Mon, 20 Feb 2012 09:16:19 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux)

Luiz Capitulino <address@hidden> writes:

> It's not needed. Besides we can then assume that bdrv_eject() is
> only called when there's a tray state change, which is useful to
> the DEVICE_TRAY_MOVED event (going to be added in a future
> commit).

We can assume that only after the next patch "ide: drop
ide_tray_state_post_load()", actually.  I'd swap the two.  Doubtful
whether it's worth a respin, though.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]