[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 3/7] qxl: introduce QXLCookie
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [RFC 3/7] qxl: introduce QXLCookie |
Date: |
Mon, 20 Feb 2012 11:56:58 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120210 Thunderbird/10.0.1 |
> + if (cookie == NULL) {
> + cookie = qxl_cookie_new(QXL_COOKIE_TYPE_IO,
> + QXL_IO_UPDATE_AREA_ASYNC,
> + 0);
> + }
Automagic cookie creation is still there.
I think when cookie is NULL you should just pass it on ...
> -/* called from spice server thread context only */
> -static void interface_async_complete(QXLInstance *sin, uint64_t cookie)
> +static void interface_async_complete_io(PCIQXLDevice *qxl, QXLCookie *cookie)
> {
> - PCIQXLDevice *qxl = container_of(sin, PCIQXLDevice, ssd.qxl);
> uint32_t current_async;
... and do "if (cookie == NULL) return;" here.
Which spice server version added async support? IIRC this is 0.8.2?
I'm tempted to raise the minimal supported version to 0.8.latest and zap
a bunch of #ifdefs from the code. What do you think?
cheers,
Gerd
[Qemu-devel] [RFC 6/7] qxl: use spice_qxl_update_area_dirty_async, Alon Levy, 2012/02/19
[Qemu-devel] [RFC 7/7] qxl: add allocator, Alon Levy, 2012/02/19