[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback |
Date: |
Wed, 22 Feb 2012 15:22:11 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120210 Thunderbird/10.0.1 |
Hi,
> Honestly, for this particular case, I'm not 100% sure that having an id is
> _required_, as I don't expect a client to submit multiple screendump calls
> in parallel and we don't "officially" support multiple QMP clients either.
> Also, having the screendump filename in the event will serve as a form of
> identifier too.
That is exactly my thinking, echo the filename written in the event.
> Btw, are you planning to add the event to the already existing screendump
> command? Adding a new command that doesn't use the monitor async API and
> is truly asynchronous wouldn't better?
Good question. I'd tend to just let the existing command send trigger
an event. But libvirt needs some way to figure whenever it should wait
for an event ...
cheers,
Gerd
- Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback, (continued)
- Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback, Gerd Hoffmann, 2012/02/20
- Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback, Eric Blake, 2012/02/20
- Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback, Alon Levy, 2012/02/21
- Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback, Eric Blake, 2012/02/21
- Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback, Alon Levy, 2012/02/21
- Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback, Luiz Capitulino, 2012/02/22
- Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback, Alon Levy, 2012/02/22
- Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback, Luiz Capitulino, 2012/02/22
- Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback,
Gerd Hoffmann <=
- Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback, Alon Levy, 2012/02/22
- Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback, Luiz Capitulino, 2012/02/22
- Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback, Alon Levy, 2012/02/22
- Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback, Luiz Capitulino, 2012/02/22
- Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback, Alon Levy, 2012/02/22
- Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback, Gerd Hoffmann, 2012/02/22
- Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback, Alon Levy, 2012/02/22