[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs |
Date: |
Wed, 22 Feb 2012 10:47:36 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1 |
On 02/22/2012 10:35 AM, Anthony Liguori wrote:
>> [1] JSON schema definition:
>>
>> { 'type': 'SnapshotDev',
>> 'data': {'device': 'str', 'snapshot-file': 'str', '*format': 'str' } }
>>
>> { 'command': 'blockdev-group-snapshot-sync',
>> 'data': { 'dev': [ 'SnapshotDev' ] } }
>
>
> This will end up looking like:
>
> { "execute": "blockdev-group-snapshot-sync",
> "arguments": { "dev": [{"device": "ide-hd0"....}] } }
Does that mean we want it to look more like:
{ 'command': 'blockdev-group-snapshot-sync',
'data': { 'devlist': [ 'SnapshotDev' ] } }
and used like:
{ "execute": "blockdev-group-snapshot-sync",
"arguments": { "devlist": [{ "device": "ide-hd0" ...},
{ "device": "ide-hd1" ...}] } }
I don't quite care what syntax we use, as long as we settle on something
soon, because I'm trying to code up libvirt to generate this new monitor
command, and need to know what syntax it will use.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/3] Group Live Snapshots, Jeff Cody, 2012/02/20
- [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs, Jeff Cody, 2012/02/20
- Re: [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs, Jeff Cody, 2012/02/22
- Re: [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs, Luiz Capitulino, 2012/02/22
- Re: [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs, Anthony Liguori, 2012/02/22
- Re: [Qemu-devel] [PATCH 1/3] qapi: Allow QMP/QAPI commands to have array inputs, Luiz Capitulino, 2012/02/22
[Qemu-devel] [PATCH 3/3] qapi: Introduce blockdev-query-group-snapshot-failure, Jeff Cody, 2012/02/20
[Qemu-devel] [PATCH 2/3] qapi: Introduce blockdev-group-snapshot-sync command, Jeff Cody, 2012/02/20