qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V14 2/7] Add TPM (frontend) hardware interface (


From: Stefan Berger
Subject: Re: [Qemu-devel] [PATCH V14 2/7] Add TPM (frontend) hardware interface (TPM TIS) to Qemu
Date: Thu, 23 Feb 2012 15:47:08 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110928 Fedora/3.1.15-1.fc14 Lightning/1.0b3pre Thunderbird/3.1.15

On 02/20/2012 10:48 AM, Stefan Berger wrote:
On 02/20/2012 03:51 AM, Michael S. Tsirkin wrote:


+static const MemoryRegionOps tpm_tis_memory_ops = {
+    .read = tpm_tis_mmio_read,
+    .write = tpm_tis_mmio_write,
+    .endianness = DEVICE_NATIVE_ENDIAN,
Are you sure? Most devices are BIG or LITTLE.


Right, it should be BIG endian. I'll fix it. Luckily there are only a few 32bit accesses (and no 16bit access) also in

Replace that with 'LITTLE endian'.

   Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]