[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/6] Endian fixes for virtfs
From: |
Aneesh Kumar K.V |
Subject: |
Re: [Qemu-devel] [PATCH 4/6] Endian fixes for virtfs |
Date: |
Fri, 24 Feb 2012 13:59:57 +0530 |
User-agent: |
Notmuch/0.11.1+190~g31a336a (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
On Fri, 24 Feb 2012 11:23:30 +1100, David Gibson <address@hidden> wrote:
> From: Benjamin Herrenschmidt <address@hidden>
>
> This patch fixes several endian bugs in virtfs.
>
> Cc: Aneesh Kumar K.V <address@hidden>
>
> Signed-off-by: Benjamin Herrenschmidt <address@hidden>
> Signed-off-by: David Gibson <address@hidden>
> ---
> hw/9pfs/virtio-9p.c | 8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c
> index a72ffc3..c633fb9 100644
> --- a/hw/9pfs/virtio-9p.c
> +++ b/hw/9pfs/virtio-9p.c
> @@ -1349,7 +1349,9 @@ static void v9fs_open(void *opaque)
> if (s->proto_version == V9FS_PROTO_2000L) {
> err = pdu_unmarshal(pdu, offset, "dd", &fid, &mode);
> } else {
> - err = pdu_unmarshal(pdu, offset, "db", &fid, &mode);
> + uint8_t modebyte;
> + err = pdu_unmarshal(pdu, offset, "db", &fid, &modebyte);
> + mode = modebyte;
> }
> if (err < 0) {
> goto out_nofid;
> @@ -3260,9 +3262,9 @@ void handle_9p_output(VirtIODevice *vdev, VirtQueue *vq)
>
> ptr = pdu->elem.out_sg[0].iov_base;
>
> - memcpy(&pdu->size, ptr, 4);
> + pdu->size = le32_to_cpu(*(uint32_t *)ptr);
> pdu->id = ptr[4];
> - memcpy(&pdu->tag, ptr + 5, 2);
> + pdu->tag = le16_to_cpu(*(uint16_t *)(ptr + 5));
> qemu_co_queue_init(&pdu->complete);
> submit_pdu(s, pdu);
> }
Reviewed-by: Aneesh Kumar K.V <address@hidden>
-aneesh