Re: [Qemu-devel] [PATCH 0/5]: Improve machine type functions

[Luiz Capitulino]

On Fri, 24 Feb 2012 08:58:55 -0600
Anthony Liguori <address@hidden> wrote:

> On 02/24/2012 08:13 AM, Luiz Capitulino wrote:
> > I was reading some related code yesterday and couldn't resist improving 
> > this.
> > Not sure if this is aligned with any possible QOM work in this area, but I'm
> > posting this anyway...
> 
> I'm not sure how easy this is, but the way to do this with QOM would be:

This seems like a cool thing to work on. The two major problems (for me at 
least)
is testing and the possible huge amount of manual work, or do you think that
most of the work can be automated?

The problem with testing is that, we have a whole lot of machines I have no idea
what's the best way of testing the conversion work.

[...]

> That's not to say this series isn't a good cleanup.  I haven't actually 
> reviewed 
> it yet.  I just wanted to illustrate the next QOM steps.

Ok. I honestly think that this series is a small first step. Even the QTAILQ
conversion is worth it IMHO, because it clearly shows what the function is doing
in a single line.