Re: [Qemu-devel] drive transactions (was Re: [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands)

[Luiz Capitulino]

On Mon, 27 Feb 2012 10:42:31 -0600
Anthony Liguori <address@hidden> wrote:

> On 02/27/2012 10:33 AM, Federico Simoncelli wrote:
> > I'm all for the modularity of the commands (I suggested it since the 
> > beginning),
> > but all this infrastructure goes way beyond what I'd need for oVirt now.
> >
> > When I submitted my patches we knew that my work wasn't the definitive 
> > solution
> > (eg: the future implementation of -blockdev). So I'd suggest to try and 
> > settle
> > with something that is good enough and that is not preventing a future 
> > improvement.
> >
> > What about having a (temporary) flag in drive-mirror to accept also a 
> > new-image-file
> > until we will have the optimal solution?
> 
> Unless there are extenuating circumstances (like the absence of core 
> infrastructure in QEMU), then we should not add commands that we know are not 
> the right command.
> 
> We have to support our commands forever.

Agreed. Worst case we have vendor extension support that downstream can use to
add its own commands.